FieldWorks icon indicating copy to clipboard operation
FieldWorks copied to clipboard
verified publisher icon sillsdev

Fix LT-21797: Missing highlights in Analyze tab

Open jtmaxwell3 opened this issue 1 year ago • 2 comments

Implementing LT-21777 (Mark guessed analyses in InterlinearExport) broke the highlighting in the interlinear display because the extra AddProp threw the display code off. I changed the code to mark the guessed analysis using set_StringProp instead, which required me to implement set_StringProp in CollectorEnv.

This change is Reviewable

jtmaxwell3 avatar May 22 '24 17:05 jtmaxwell3

CollectorEnv is used by multiple clients. None of them currently make use of set_StringProp, but I figured that as long as I was going to implement that function, I should implement it for the general case and not just for InterlinearExplorer's current need. In the general case, set_StringProp could be called multiple times before the next AddObj, so it seemed appropriate to use a Dictionary for the properties.

jtmaxwell3 avatar May 23 '24 15:05 jtmaxwell3

I'm not sure what you mean by multiple derived classes. I meant that CollectorEnv is used by ConfiguredExport, ItemsCollectorEnv, FindCollectorEnv, and DiscourseExporter in addition to InterlinearExporter. The original comment on set_StringProp said "Nothing to do here. None of our collectors cares about string properties (yet)", so I wanted to future-proof my change.

jtmaxwell3 avatar May 23 '24 16:05 jtmaxwell3