Mukesh comments

Results 81 comments of


                                            Mukesh

Extracting columns that aren't orderable into a different tables results in incorrect data

#1436 needs to be merged for this bug to be valid, marking it as draft until then

Reduce db functions to one SQLAlchemy operation per function

@vrutik2809 I think this issue needs some in-depth knowledge about the codebase, I was wrong about tagging this as a `good first issue`. I have unassigned you, Please feel free...

Reduce db functions to one SQLAlchemy operation per function

Quoted from the proposed solution > `Each function should use only one SQLAlchemy operation` @Anish9901 Function `alter_column` does not call any SQLALchemy operations, it composes of multiple functions which take...

Mathesar 946 record preview data

I am going to make the changes to the API just as we discussed. ```json5 //Example schema { "count": 1393, "grouping": {}, "previews_render": [ { "column": 10 // "Items"."Id", "template":...

Consistent error handling across the API

@dmos62 @mathemancer @kgodey Let me know if this list makes sense

Consistent error handling across the API

@dmos62 The filters should throw custom exceptions, which shows that the problem is with the filter. But custom code is more of an API requirement and the exceptions shouldn't have...

Public functions should use attnums instead of column index or column name

@vrutik2809 Sorry for the late reply, I missed the Github notification. I don't have much to add to @mathemancer's comment.

Accept type_options when testing type casts, making it possible to test every type cast

@jjram20 Thanks! I have assigned it to you.

Accept type_options when testing type casts, making it possible to test every type cast

Sure @Jayitha, that shouldn't be a problem

Moving columns from referent table to referrer table should result in normalized data

@mathemancer @kgodey @ghislaineguerin I would like your opinion on the need for a normalized table after a column is moved away from a referent table.