Takeru Ohta

Results 123 comments of Takeru Ohta
trafficstars

I had a similar problem: ```console $ lsb_release -a No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focal // https://github.com/iovisor/bcc/blob/master/INSTALL.md#ubuntu---source $ git clone...

Thanks for your advice. It seems useful. I added `impl Drop` for encoders at the commit https://github.com/sile/libflate/commit/e7ec99bae233052fcf001b43d70294bd6e27c829. Because this change breaks compatibility with previous versions, I will publish this as...

I reverted the above commit because implementing `Drop` trait directly for encoders seemed to make it difficult to handle errors. Instead, I tried adding `AutoFinish` (and `AutoFinshUnchecked`) for this purpose...

> For comparison I've also been using `tar::Builder` which has to solve problems similar to gzip encoder. Thank you for the information. It seems okay to implement the `Drop` trait...

@DevQps Thanks for your question. This feature has not been merged into `master` branch.

@DevQps To be honest, I forgot about this feature. If you need it, I will consider it again, but what about it?

@DevQps I see, thanks! I will keep this PR open.

Sounds good. Please go for it!

Thank you for reporting this issue. Could you share the code for reproducing this problem in my environment?

@mjc Thank you for your information! I will try to reproduce it on my local machine.