model-transparency icon indicating copy to clipboard operation
model-transparency copied to clipboard

Published 20 hours ago • verified publisher icon sigstore

Make python typing and linting errors be displayed in the PR review tab

Open mihaimaruseac opened this issue 1 year ago • 4 comments
trafficstars

Right now, if python linting/type checking fails, we need to go to the report in the workflow.

It would be ideal to have github formatted output showing up to files in the PRs on the lines that are not ok.

mihaimaruseac avatar Aug 15 '24 18:08 mihaimaruseac

Hey @mihaimaruseac, I'd like to pick this up

rakshitgondwal avatar Oct 18 '24 16:10 rakshitgondwal

We don't block issues on who declares to work on them, we just look at the PRs. Please feel free to work on it and I'm looking forward to the PR. Thank you

mihaimaruseac avatar Oct 19 '24 12:10 mihaimaruseac

Hello @mihaimaruseac. I would like to work on this issue!

alexecse avatar Nov 16 '24 09:11 alexecse

Awesome. Please see #293 and #295 as starting points, as those were made to make the test coverage visible in the PR review, something very similar to this.

mihaimaruseac avatar Nov 16 '24 15:11 mihaimaruseac

@mihaimaruseac - Can we mark this issue as fixed/closed as we have merged this https://github.com/sigstore/model-transparency/pull/509

hotcodemacha avatar Aug 04 '25 18:08 hotcodemacha

Oh, for sure! Thank you

mihaimaruseac avatar Aug 05 '25 13:08 mihaimaruseac