cosign icon indicating copy to clipboard operation
cosign copied to clipboard

Update e2e tests - update workflow to use workload identity instead of key

Open cpanato opened this issue 3 years ago • 1 comments

Summary

  • update workflow to use workload identity instead of key

Before we merge this, we need to add the service account the permission for the workload identity, delete the existing key and then we can remove the secret from the repository.

I don't have enough permission to make this change in the GCP project, wondering if @dlorenc or @bobcallaway can do that.

cpanato avatar Sep 15 '22 10:09 cpanato

Codecov Report

Merging #2252 (7339eda) into main (fb9eca5) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2252   +/-   ##
=======================================
  Coverage   30.91%   30.91%           
=======================================
  Files         139      139           
  Lines        8645     8645           
=======================================
  Hits         2673     2673           
  Misses       5613     5613           
  Partials      359      359           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Sep 15 '22 10:09 codecov-commenter

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Nov 11 '22 02:11 github-actions[bot]

ping @bobcallaway @dlorenc need to get this in to fix the failing tests in the main branch

cpanato avatar Nov 18 '22 10:11 cpanato

failing tests: https://github.com/sigstore/cosign/actions/runs/3491718365/jobs/5844677366

cpanato avatar Nov 18 '22 12:11 cpanato

Yah I can do it! @cpanato just lmk what the SA name and roles should be

priyawadhwa avatar Nov 18 '22 16:11 priyawadhwa

going to merge, if anything fail will fix in a follow up

cpanato avatar Nov 23 '22 13:11 cpanato