lighthouse icon indicating copy to clipboard operation
lighthouse copied to clipboard
verified publisher icon sigp

Drop verify single RpcBlock fns

Open dapplion opened this issue 9 months ago • 4 comments

Issue Addressed

Noted that we never have to verify individual RpcBlocks for sync. Lookup sync sends the block alone always, and range sync sends chain segments.

Proposed Changes

  • Removed verify_kzg_for_rpc_block
  • Removed IntoExecutionPendingBlock impl for RpcBlock. Now lookup sync blocks use the SignedBeaconBlock IntoExecutionPendingBlock impl which is the same
  • Switched tests to import RpcBlocks with process_chain_segment

dapplion avatar Feb 18 '25 04:02 dapplion

Should we merge this before:

  • https://github.com/sigp/lighthouse/pull/6866

?

michaelsproul avatar Feb 18 '25 06:02 michaelsproul

Should we merge this before

Independent, I can fix conflicts later.

dapplion avatar Feb 18 '25 15:02 dapplion

This pull request has merge conflicts. Could you please resolve them @dapplion? 🙏

mergify[bot] avatar May 19 '25 05:05 mergify[bot]

Some required checks have failed. Could you please take a look @dapplion? 🙏

mergify[bot] avatar May 19 '25 05:05 mergify[bot]

Hi @dapplion, this pull request has been closed automatically due to 30 days of inactivity. If you’d like to continue working on it, feel free to reopen at any time.

mergify[bot] avatar Jun 18 '25 05:06 mergify[bot]