lighthouse icon indicating copy to clipboard operation
lighthouse copied to clipboard

`SingleAttestation` implementation

Open eserilev opened this issue 1 year ago • 1 comments

Issue Addressed

Closes https://github.com/sigp/lighthouse/issues/6380

Proposed Changes

Spec: ethereum/consensus-specs#3900

Convert single attestation as early as possible to reduce code diff

eserilev avatar Oct 15 '24 04:10 eserilev

bell curve @dapplion

eserilev avatar Oct 15 '24 19:10 eserilev

I've ran some kurtosis tests interoping against prysm and we are attesting correctly

EDIT: we are NOT interoping correctly at the moment. I am working on debugging the issue

eserilev avatar Nov 28 '24 05:11 eserilev

Most of the added diff is tests I included for single attestations

eserilev avatar Jan 06 '25 09:01 eserilev

I've just re-targeted this at the electra-alpha10 branch so we can get a conga-line going.

michaelsproul avatar Jan 10 '25 04:01 michaelsproul

Looks like one of the SSE tests is failing (get_events)

michaelsproul avatar Jan 15 '25 08:01 michaelsproul

I believe i've fixed the test failure but I think I need to add some test coverage for the new single_attestation event topic

eserilev avatar Jan 15 '25 09:01 eserilev

i've added test coverage for the new single_attestation event topic. This PR should hopefully be good to go

eserilev avatar Jan 16 '25 04:01 eserilev

@mergify queue

pawanjay176 avatar Jan 16 '25 17:01 pawanjay176

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 06329ec2d105fc60c4c7218561cff11fb6b398a3

mergify[bot] avatar Jan 16 '25 17:01 mergify[bot]