lighthouse icon indicating copy to clipboard operation
lighthouse copied to clipboard

chore: update and enable PeerDAS tests to latest spec test release (`1.5.0-alpha-5`)

Open kevaundray opened this issue 1 year ago • 2 comments

Issue Addressed

This enables the peerDAS test which were previously commented out. The main issue for this seems to be rayon's local threadpool not working well with rayon's global threadpool. The local threadpool has been disabled along with rayon following 6309

Proposed Changes

This PR is built ontop of 6309 and 6312, so the diff is more than it should be.

The changes introduced in this PR:

  • Modify the spec test for verify_cell_kzg_proof_batch so that its forward compatible with the new API. Once the consensus-specs are updated, we can remove the TODOs.

  • Removed the commenting out of the kzg tests.

Additional Info

Please provide any additional information. For example, future considerations or information useful for reviewers.

kevaundray avatar Aug 27 '24 13:08 kevaundray

This is dependent on #6309 and #6311

kevaundray avatar Aug 27 '24 13:08 kevaundray

Seems CI is unstable with the test network sync::block_lookups::tests::sampling_with_retries

dapplion avatar Aug 28 '24 07:08 dapplion

Raised issue for the flaky test https://github.com/sigp/lighthouse/issues/6319

jimmygchen avatar Aug 28 '24 10:08 jimmygchen

@mergify queue

jimmygchen avatar Aug 28 '24 10:08 jimmygchen

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 653126f42ec6eb3a6a2f5e643076283033a3d54d

mergify[bot] avatar Aug 28 '24 10:08 mergify[bot]