lighthouse icon indicating copy to clipboard operation
lighthouse copied to clipboard

Add test for ActiveSamplingRequest

Open ackintosh opened this issue 1 year ago • 2 comments

Issue Addressed

I've implemented batching sampling requests in #6256, but there are no unit tests for it yet.

Proposed Changes

Add a test for ActiveSamplingRequest to ensure that the requests are batched, and check the status of the requests.

ackintosh avatar Aug 26 '24 22:08 ackintosh

Please update to point at unstable by either:

  1. Rebasing on unstable (if your branch has a small number of commits that are easy to tease out), or
  2. Merging origin/das into this PR: git fetch origin; git merge origin/das. This will result in the smallest number of conflict resolutions and is better for branches that already contain merge commits or have extensive history.

michaelsproul avatar Aug 27 '24 05:08 michaelsproul

Thanks for the comment Michael! I've rebased this on unstable.

ackintosh avatar Aug 27 '24 22:08 ackintosh

Thanks @dapplion! I've written tests in the tests.rs file.

ackintosh avatar Aug 31 '24 12:08 ackintosh

@mergify queue

jimmygchen avatar Oct 04 '24 02:10 jimmygchen

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 8cf686f5c11cbad19727885d07df5abfddeddb0f

mergify[bot] avatar Oct 04 '24 02:10 mergify[bot]