lighthouse icon indicating copy to clipboard operation
lighthouse copied to clipboard
verified publisher icon sigp

Make `BeaconChain::kzg` field mandatory

Open eserilev opened this issue 1 year ago • 1 comments

Issue Addressed

Closes #6260

Proposed Changes

Make the kzg field in BeaconChain and BeaconChainBuilder mandatory

eserilev avatar Aug 16 '24 00:08 eserilev

This PR adds a new trusted setup, is that expected?

dapplion avatar Aug 28 '24 08:08 dapplion

removed the extraneous trusted setup. It looks like loading KZG has added like 5 min to a few CI test groups. I'm going to dig in there and make sure were not doing any KZG precomputation when possible. Kevs recent PR makes this easy to do

eserilev avatar Aug 29 '24 01:08 eserilev

There no longer seems to be any noticeable difference in CI times between this branch and unstable

eserilev avatar Aug 29 '24 18:08 eserilev

@mergify queue

michaelsproul avatar Sep 23 '24 04:09 michaelsproul

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at b619f1ab5c3ba9b610f12b7353383b2bcefb1ca4

mergify[bot] avatar Sep 23 '24 04:09 mergify[bot]