lighthouse
lighthouse copied to clipboard
Add additional PeerDAS metrics (#6018)
Issue Addressed
This PR addresses issue #6018, the list of the additional PeerDAS metrics.
Proposed Changes
Added the following metrics:
Custody:
- Total count of columns in custody (counter)
Gossipsub:
- Number of bytes received from each topic (deduplicated) (counter)
Libp2p:
- Number of requests received (counter)
- Number of responses received (counter)
Renamed topic_msg_recv_bytes metric to topic_msg_recv_bytes_unfiltered. It's kind of a breaking change but I guess metrics names should be put in order or we will have _unfiltered/_filtered mess. It's up to you, please share your feedback
@jxs could you please review the libp2p metrics we've discussed?
Added Req/Resp metrics:
- Number of requests sent (counter)
- Number of requests bytes sent (counter)
- Number of responses sent (counter)
- Number of responses bytes sent (counter)
- Number of requests bytes received (counter)
- Number of responses bytes received (counter)
Please update to point at unstable by either:
- Rebasing on
unstable(if your branch has a small number of commits that are easy to tease out), or - Merging
origin/dasinto this PR:git fetch origin; git merge origin/das. This will result in the smallest number of conflict resolutions and is better for branches that already contain merge commits or have extensive history.