lighthouse icon indicating copy to clipboard operation
lighthouse copied to clipboard

Add additional PeerDAS metrics (#6018)

Open KatyaRyazantseva opened this issue 1 year ago • 5 comments

Issue Addressed

This PR addresses issue #6018, the list of the additional PeerDAS metrics.

Proposed Changes

Added the following metrics:

Custody:

  • Total count of columns in custody (counter)

Gossipsub:

  • Number of bytes received from each topic (deduplicated) (counter)

Libp2p:

  • Number of requests received (counter)
  • Number of responses received (counter)

KatyaRyazantseva avatar Aug 09 '24 15:08 KatyaRyazantseva

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 09 '24 15:08 CLAassistant

Renamed topic_msg_recv_bytes metric to topic_msg_recv_bytes_unfiltered. It's kind of a breaking change but I guess metrics names should be put in order or we will have _unfiltered/_filtered mess. It's up to you, please share your feedback

KatyaRyazantseva avatar Aug 09 '24 15:08 KatyaRyazantseva

@jxs could you please review the libp2p metrics we've discussed?

KatyaRyazantseva avatar Aug 22 '24 19:08 KatyaRyazantseva

Added Req/Resp metrics:

  • Number of requests sent (counter)
  • Number of requests bytes sent (counter)
  • Number of responses sent (counter)
  • Number of responses bytes sent (counter)
  • Number of requests bytes received (counter)
  • Number of responses bytes received (counter)

KatyaRyazantseva avatar Aug 23 '24 08:08 KatyaRyazantseva

Please update to point at unstable by either:

  1. Rebasing on unstable (if your branch has a small number of commits that are easy to tease out), or
  2. Merging origin/das into this PR: git fetch origin; git merge origin/das. This will result in the smallest number of conflict resolutions and is better for branches that already contain merge commits or have extensive history.

michaelsproul avatar Aug 27 '24 05:08 michaelsproul