lighthouse icon indicating copy to clipboard operation
lighthouse copied to clipboard

Published 20 hours ago • verified publisher icon sigp

Use `MIN_EPOCHS_FOR_DATA_COLUMN_SIDECARS_REQUESTS` and `MAX_REQUEST_DATA_COLUMN_SIDECARS` for data columns

Open jimmygchen opened this issue 1 year ago • 2 comments

Description

The current das branch incorrectly re-used the Deenb MIN_EPOCHS_FOR_BLOB_SIDECARS_REQUESTS for data column sidecars.

  • There's a new config value for this, MIN_EPOCHS_FOR_DATA_COLUMN_SIDECARS_REQUESTS, which should be used instead. This should be configurable at run time (config value).
  • Also added MAX_REQUEST_DATA_COLUMN_SIDECARS

Spec: https://github.com/ethereum/consensus-specs/blob/8f8ab03acf1656c54f3a81ef18878f853a1cc4c6/specs/_features/eip7594/p2p-interface.md#configuration

jimmygchen avatar Aug 07 '24 13:08 jimmygchen

I'll try to raise a pr for this.

startup-dreamer avatar Mar 14 '25 05:03 startup-dreamer

Update: MAX_REQUEST_DATA_COLUMN_SIDECAR removed from spec https://github.com/ethereum/consensus-specs/pull/4322

jimmygchen avatar May 16 '25 04:05 jimmygchen

Completed in #7646

jimmygchen avatar Jul 02 '25 03:07 jimmygchen