lighthouse icon indicating copy to clipboard operation
lighthouse copied to clipboard

Add PeerDAS DataColumn type

Open dapplion opened this issue 1 year ago • 3 comments

Issue Addressed

First step to progressively merge das into unstable. Almost all changes use the DataColumnSidecar type so its a pre-requisite for anything else.

DataColumnSidecar includes some methods that require a newer version of ckzg-4844. Currently, these changes live in the das branch https://github.com/ethereum/c-kzg-4844/tree/das. I propose to merge the DataColumnSidecar with no-op crypto until c-kzg-4844 changes land on main, which should happen in < 2 months.

Since this PR does not introduce any actual functionality of PeerDAS it does not make a big difference to have the actual crypto backend. Once we merge enough pieces of the das branch to be able to run a PeerDAS node we can switch to c-kzg-4844/das.

Proposed Changes

Introduce the DataColumnSidecar type from

  • https://github.com/sigp/lighthouse/pull/5683

dapplion avatar Jun 11 '24 08:06 dapplion

There has been very little interest in progressively merging PeerDAS in atomic PRs so I wave a white flag and join the group of yoloing das into unstable

dapplion avatar Jun 27 '24 16:06 dapplion

I thought I already waved mine a while ago 😅 I think @pawanjay176 might have started looking into this, I'll bring it up again to make sure we keep the ball rolling.

jimmygchen avatar Jun 28 '24 01:06 jimmygchen

What a comeback! 🔥 We should include Kev's lib in this PR to have mock crypto

dapplion avatar Jun 28 '24 09:06 dapplion

@mergify queue

realbigsean avatar Jul 09 '24 16:07 realbigsean

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 15985b87686720a192a2c01ed9f8e0d552ec3765

mergify[bot] avatar Jul 09 '24 16:07 mergify[bot]