lighthouse icon indicating copy to clipboard operation
lighthouse copied to clipboard

Published 20 hours ago • verified publisher icon sigp

Change DB Manager Clap usage to derive

Open eserilev opened this issue 1 year ago • 2 comments

partially #5900

This is part of a series of PRs that aims to move the Lighthouse cli to clap derive. This PR moves the db manager crate to clap derive and introduces the ability to include clap derive subcommands within our existing clap builder flag definitions.

eserilev avatar Jun 06 '24 13:06 eserilev

Noticed that e.g. lighthouse db inspect --help doesn't work. We might want to declare the help flag as a global flag or something?

michaelsproul avatar Jun 19 '24 05:06 michaelsproul

nice catch, 897bd8d defines the help flag as global now. this seems to have fixed the issue

eserilev avatar Jun 19 '24 13:06 eserilev

@mergify queue

jimmygchen avatar Jul 12 '24 06:07 jimmygchen

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at b7b5dd7ec9a765542a20d77be8e8defde92b0a50

mergify[bot] avatar Jul 12 '24 06:07 mergify[bot]