lighthouse icon indicating copy to clipboard operation
lighthouse copied to clipboard

Log warning on startup if chain spec contains misaligned fork epochs

Open jimmygchen opened this issue 1 year ago • 1 comments

Issue Addressed

Addresses this comment: https://github.com/sigp/lighthouse/pull/4946#discussion_r1475547414

If fork epochs are not multiples of 256, sync committee period may span across forks - this is mostly fine for non-production and testing code unrelated to light client. Adding a check would be useful for identifying issues with future forks / light client testing.

Proposed Changes

Check fork epochs in the ChainSpec are aligned with the start of sync committee period, otherwise log a warning durinog startup.

jimmygchen avatar May 29 '24 00:05 jimmygchen

The intent was mainly for setting up expectation and giving a heads up on the configuration during testing (local devnet / testnets).

So yes, this only applies to local devnet and experiments, and we should never see this on a production network.

jimmygchen avatar Jun 03 '24 01:06 jimmygchen

@mergify queue

jimmygchen avatar Jul 11 '24 05:07 jimmygchen

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 4c7277c6461288bd01a5e9b966422e176b866e91

mergify[bot] avatar Jul 11 '24 05:07 mergify[bot]