lighthouse icon indicating copy to clipboard operation
lighthouse copied to clipboard

Published 20 hours ago • verified publisher icon sigp

refactor: reduce code duplication and remove unnecesary strings

Open 1010adigupta opened this issue 1 year ago • 5 comments

Issue Addressed

closes #5745

Proposed Changes

modifies code according to issue description, removes some boilerplate comments and reduces code duplication.

1010adigupta avatar May 10 '24 09:05 1010adigupta

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 10 '24 09:05 CLAassistant

if some other comments need to be removed then kindly tell

1010adigupta avatar May 10 '24 09:05 1010adigupta

@chong-he all suggested changes have been addressed, can merge

1010adigupta avatar May 19 '24 16:05 1010adigupta

Hi @1010adigupta Latest development is happening on the unstable branch, and all PRs should target unstable. I've modified the target branch of this PR.

However it looks like this was built on top of stable, could you please make the changes on unstable instead? Thanks!

jimmygchen avatar May 29 '24 07:05 jimmygchen

@1010adigupta Could you please merge the latest unstable to update this PR and solve the conflicts, as @jimmygchen mentioned?

There are some light client RPCs (#3849) that are in the latest unstable. Need to merge the fields related to LightClientOptimisticUpdate and LightClientFinalityUpdate to your PR.

Thanks!

chong-he avatar Jul 31 '24 04:07 chong-he