signalwire-python icon indicating copy to clipboard operation
signalwire-python copied to clipboard

Upgrade Twilio and dockerfile (python 3.13-slim)

Open bnjmn opened this issue 11 months ago • 4 comments

I've upgraded Twilio and all dependencies in Pipfile. This requires minimum python 3.9 now which I believe is reasonable since 3.8 is EOL.

Here are the current versions that are installed for each package for reference (all tests currently passing on my machine.

(EDIT: See comment below for final versions)

root@b65291349603:/app# pipenv requirements
-i https://pypi.org/simple
aiohappyeyeballs==2.4.4; python_version >= '3.8'
aiohttp==3.11.11; python_version >= '3.9'
aiohttp-retry==2.8.3; python_version >= '3.7'
aiosignal==1.3.2; python_version >= '3.9'
attrs==24.3.0; python_version >= '3.8'
certifi==2024.12.14; python_version >= '3.6'
charset-normalizer==3.4.1; python_version >= '3.7'
frozenlist==1.5.0; python_version >= '3.8'
idna==3.10; python_version >= '3.6'
multidict==6.1.0; python_version >= '3.8'
propcache==0.2.1; python_version >= '3.9'
pyjwt==2.10.1; python_version >= '3.9'
pytz==2024.2
requests==2.32.3; python_version >= '3.8'
-e . ; python_version >= '3.6'
six==1.17.0; python_version >= '2.7' and python_version not in '3.0, 3.1, 3.2'
twilio==9.4.1; python_full_version >= '3.7.0'
urllib3==2.3.0; python_version >= '3.9'
yarl==1.18.3; python_version >= '3.9'

Related to #85 – I tried python 3.13 and 3.12 but would also need to install gcc Duplicates #95 Closes #78

I suggest merging this and making a new 3.0 (or 2.2.0) release of SignalWire Python SDK if possible. That would be great; Thanks!

bnjmn avatar Jan 03 '25 17:01 bnjmn

Ran into some issues due to twilio having removed their support for Fax in version 7.6.0

Current dependencies for reference are now:

root@4f4a07cb12a6:/app# pipenv requirements
-i https://pypi.org/simple
aiohappyeyeballs==2.4.4; python_version >= '3.8'
aiohttp==3.11.11; python_version >= '3.9'
aiosignal==1.3.2; python_version >= '3.9'
attrs==24.3.0; python_version >= '3.8'
certifi==2024.12.14; python_version >= '3.6'
charset-normalizer==3.4.1; python_version >= '3.7'
frozenlist==1.5.0; python_version >= '3.8'
idna==3.10; python_version >= '3.6'
multidict==6.1.0; python_version >= '3.8'
propcache==0.2.1; python_version >= '3.9'
pyjwt==2.10.1; python_version >= '3.9'
pytz==2024.2
requests==2.32.3; python_version >= '3.8'
-e . ; python_version >= '3.6'
six==1.17.0; python_version >= '2.7' and python_version not in '3.0, 3.1, 3.2'
twilio==7.5.1; python_full_version >= '3.6.0'
urllib3==2.3.0; python_version >= '3.9'
yarl==1.18.3; python_version >= '3.9'

bnjmn avatar Jan 03 '25 18:01 bnjmn

@jpsantosbh Hello! Can you take a look at this when you have a chance? Should be ready to merge at this point as far as I can tell but let me know if you need anything else; all tests are passing for me locally right now. Thanks!

bnjmn avatar Jan 03 '25 18:01 bnjmn

Thanks @bnjmn could you sync this with main again?

jpsantosbh avatar Mar 25 '25 20:03 jpsantosbh

@jpsantosbh done! Let me know if you need anything else on it. Thanks!

bnjmn avatar Mar 25 '25 22:03 bnjmn

@jpsantosbh Thank you for getting the merged. Will there be a new version of the python package released to pypi at some point to include this?

bnjmn avatar Apr 08 '25 17:04 bnjmn

@bnjmn it's published already https://pypi.org/project/signalwire/2.1.1/

jpsantosbh avatar Apr 09 '25 13:04 jpsantosbh

Hey @jpsantosbh — thanks for the quick reply! I just took a look at the 2.1.1 release on PyPI and it looks like it was published back in February, before my PR was merged on April 2. It still shows twilio==6.54.0 in the dependencies, so I don’t think my changes made it into that release.

Do you mind publishing a new version that includes the latest changes from main? Let me know if I can help! 🙏

bnjmn avatar Apr 09 '25 13:04 bnjmn

@jpsantosbh any update on this? As per @bnjmn's last message this is still is not published and blocking me from using the package since it is presented pinned to v1 of pyjwt. Thanks!

chasemcdo avatar May 07 '25 13:05 chasemcdo