Signal-Desktop icon indicating copy to clipboard operation
Signal-Desktop copied to clipboard

NSWindowShouldDragOnGesture on macOS is not working with Signal

Open marcolaux opened this issue 10 months ago • 6 comments

Using a supported version?

  • [X] I have searched searched open and closed issues for duplicates.
  • [X] I am using Signal-Desktop as provided by the Signal team, not a 3rd-party package.

Overall summary

With the setting NSWindowShouldDragOnGesture enabled the user is able to drag any window at any cursor position via CTRL+ALT+Mouse1.

This doesn't seem to work with current Signal versions.

Steps to reproduce

  1. defaults write -g NSWindowShouldDragOnGesture -bool true
  2. restart
  3. See that you can drag any window with CTRL+ALT+Mouse1 at any cursor position
  4. See that this doesn't work with Signal

Expected result

it works like other macOS windows

Actual result

the mouse click just gets registered as a normal mouse click

Screenshots

No response

Signal version

Signal Desktop 7.37.0 ⁨production⁩ (Apple silicon)

Operating system

macOS 15.2 (24C101)

Version of Signal on your phone

No response

Link to debug log

No response

marcolaux avatar Jan 09 '25 09:01 marcolaux

@marcolaux appears to be an issue with Electron. Did this work in previous Signal versions?

trevor-signal avatar Jan 09 '25 22:01 trevor-signal

@marcolaux appears to be an issue with Electron. Did this work in previous Signal versions?

It looks like it - thanks for the hint.

It indeed worked in previous versions and I only noticed it recently. I use the gesture regularly.

Other apps have the same issue with newer Electron versions I have been told.

marcolaux avatar Jan 09 '25 22:01 marcolaux

You seem to have most context on the issue, could you report it upstream, please? Thank you!

https://github.com/electron/electron/issues/new?template=bug_report.yml

indutny-signal avatar Jan 13 '25 17:01 indutny-signal

alright, I leave a link here:

https://github.com/electron/electron/issues/45183

marcolaux avatar Jan 13 '25 17:01 marcolaux

Thank you so much!

indutny-signal avatar Jan 13 '25 18:01 indutny-signal

alright, I leave a link here:

electron/electron#45183

FWIW I've added a comment confirming the issue and demoing differences in behavior between electron and non-electron apps for the gesture.

colinhb avatar Feb 24 '25 22:02 colinhb

@indutny-signal @trevor-signal It seems to be fixed with Electron 34. Signal 7.44.0 behaves correctly again (also other apps I tested with Electron 34)

marcolaux avatar Mar 05 '25 16:03 marcolaux