pasting an image into the message editor spawns a new message

[SuperElectric]

• [x] I have searched open and closed issues for duplicates
• [x] I am submitting a bug report for existing functionality that does not work as intended
• [x] I have read https://github.com/signalapp/Signal-Android/wiki/Submitting-useful-bug-reports
• [x] This isn't a feature request or a discussion topic

---

Bug description

When I edit a message I've already sent, the UI will seemingly allow me to paste in an image copied from my browser. When I send the edited message, though, instead of updating the existing message, it sends a new message.

Steps to reproduce

• Copy an image into the clipboard, e.g. by going to Chrome browser, holding down on some image, and selecting "copy".
• In Signal, send a text-only message
• Press down on the message you just sent, then select "Edit" in the resulting pop-up menu.
• Hold down in the edit box, and in the resulting pop-up, select "Image" to paste in the image.
• Send the edited message

Actual result: The above sends a modified copy of the old message, this time with the image attached. Expected result: The old message should be edited in-place to have the pasted image attached.

Screenshots

Device info

Device: Google Pixel 7 Pro Android version: 14, last security update on 5 Aug 2024 Signal version: 7.12.3

Link to debug log

https://debuglogs.org/android/7.12.3/3d74dc8c11845a3cfb8ad741ba1dbd96ea88c6c6c4ff6b133adaf1221ffda210

[UnreachableCode]

I've fixed this here https://github.com/signalapp/Signal-Android/pull/14069