github3.py icon indicating copy to clipboard operation
github3.py copied to clipboard

Published 20 hours ago • verified publisher icon sigmavirus24

Consider replacing requests with urllib3

Open sigmavirus24 opened this issue 8 years ago • 3 comments

See also https://github.com/kennethreitz/requests/issues/4069

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

sigmavirus24 avatar May 27 '17 12:05 sigmavirus24

For what it's worth it looks like requests reverted the change that removed the vendored packages and it's fixed in 2.16.3

gene1wood avatar Jun 06 '17 22:06 gene1wood

They did not. The dependencies are still unvendored. Requests at this point is no longer going to be stable for usage when you have a project using github3.py and something that requires a different version of urllib3. In our case, if we move to urllib3 and support a wide swath of recent versions, then we can avoid pulling out too much of our hair.

sigmavirus24 avatar Jun 08 '17 12:06 sigmavirus24

@sigmavirus24 Is this still something you want to do? If so, happy to go ahead!

usmanatron avatar Dec 17 '18 13:12 usmanatron