github3.py
github3.py copied to clipboard
Notes are required for Oauth, but optional in the api
To reproduce, follow the documentation but omit the note.
Relevant github docs here: https://developer.github.com/v3/oauth_authorizations/#create-a-new-authorization
(Tested with 2-factor-auth. Not sure if the problem exists with "normal" logins.)
Possible solutions:
- Make it no longer optional.
- Keep it optional, but create a default unique message
I think this is because GitHub broke their authorizations API and neither I nor anyone else has had time to re-implement the new Authorizations API. It isn't a simple thing to reimplement but it'll be easier now that it's the default and totally broken (and no longer in a preview window).