ix icon indicating copy to clipboard operation
ix copied to clipboard

fix(core/tab-item): update counter pill background color

Open nuke-ellington opened this issue 1 month ago โ€ข 5 comments

๐Ÿ’ก What is the current behavior?

GitHub Issue Number: #<ISSUE NUMBER>

๐Ÿ†• What is the new behavior?

๐Ÿ Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • [ ] ๐Ÿฆฎ Accessibility (a11y) features were implemented
  • [ ] ๐Ÿ—บ๏ธ Internationalization (i18n) - no hard coded strings
  • [ ] ๐Ÿ“ฒ Responsiveness - components handle viewport changes and content overflow gracefully
  • [ ] ๐Ÿ“• Add or update a Storybook story
  • [ ] ๐Ÿ“„ Documentation was reviewed/updated siemens/ix-docs
  • [x] ๐Ÿงช Unit tests were added/updated and pass (pnpm test)
  • [x] ๐Ÿ“ธ Visual regression tests were added/updated and pass (Guide)
  • [x] ๐Ÿง Static code analysis passes (pnpm lint)
  • [x] ๐Ÿ—๏ธ Successful compilation (pnpm build, changes pushed)

๐Ÿ‘จโ€๐Ÿ’ป Help & support

nuke-ellington avatar Oct 17 '25 13:10 nuke-ellington

๐Ÿฆ‹ Changeset detected

Latest commit: 6dbcef3feafff7d5e96d7303176997dad08646a7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@siemens/ix Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Oct 17 '25 13:10 changeset-bot[bot]

Summary of Changes

Hello @nuke-ellington, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a styling concern by updating the background color of the counter pill in the ix-tab-item component. The change ensures that the counter pill's background now uses the --theme-color-1 variable, promoting better consistency with the overall theme's primary color palette.

Highlights

  • Styling Update: The background color variable for the counter pill within the ix-tab-item component has been updated from --theme-pill-outline--background to --theme-color-1.
  • Changelog Entry: A new changeset file (.changeset/unlucky-bikes-punch.md) was added to document this styling patch for the ix-tab-item.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Oct 17 '25 13:10 gemini-code-assist[bot]

/release:pr

nuke-ellington avatar Oct 17 '25 13:10 nuke-ellington

A new release has been made for this PR. You can install it with:

Core library:

npm i @siemens/[email protected]

Angular:

npm i @siemens/[email protected]

React:

npm i @siemens/[email protected]

Vue:

npm i @siemens/[email protected]

github-actions[bot] avatar Oct 17 '25 13:10 github-actions[bot]