node-vim-debugger icon indicating copy to clipboard operation
node-vim-debugger copied to clipboard

jest testing / readme update

Open Anzumana opened this issue 7 years ago • 11 comments

Added jest for testing our code And updated the readme with a lot more usefull information.

the things that i am currently thinking about that could help.

============ would you be ok if we switch things over from gitter to slack ? have every little experience with gitter while slack i use on a daily basis.so i could make sure that i keep up with people that do have questions.

Also i was wondering what do you think about taking the project and making and organisation for it. I also work on the debugger for firefox. There we have an organisation and that works pretty great. https://github.com/devtools-html/debugger.html

Once we have the organisation in place i would apply to make an open collective for this project. As the main issue always tend to be how to find the proper time to work on those great side projects.

Anzumana avatar Jan 11 '18 16:01 Anzumana

Readme changes looks good ( maybe add notes about docker as an option as well )

Added jest for testing our code

So this just calls jest, but we don't have any tests yet, right? Do you have anything in mind to put as first test?

Also i was wondering what do you think about taking the project and making and organisation for it.

I don't mind moving it to org. Name suggestions? node-vim-debugger as org name? (maybe node is bad name as by moving to CDP we'll get browser client side scripts debugging from vim was well. js-vim-debugger ?)

sidorares avatar Jan 12 '18 00:01 sidorares

my initial thought was javascript-vim-debugger to make it easily searchable through google. The more traction we can generate the better. but js-vim-debugger would work for me too. i rly like the shorthand jvd for the project to be honest :) But thats the case with both names ^^

will try to add docker notes. i am not that familiar with docker yet. that kind of makes it a little bit tricky.

for testing the best place would probably be ensuring that the version for 7.6 is still viable with any future changes. So those would be the tests that i would like to create first.

I also need to setup cycle ci or travis ci for the project to make sure pr can only be merged if our tests don't fail

Anzumana avatar Jan 12 '18 10:01 Anzumana

hm not exactly sure why the markdown table is broken. in my markdown preview everything seems fine.ˆˆ will have to look into that tomorrow

Anzumana avatar Jan 16 '18 11:01 Anzumana

what are you using for preview?

sidorares avatar Jan 16 '18 22:01 sidorares

http://marked2app.com/ by @ttscoff

Anzumana avatar Jan 17 '18 11:01 Anzumana

Is this still coming into the project? I'd be super excited to see this project active again!

CADBOT avatar Aug 23 '19 06:08 CADBOT

Hey @CADBOT I'm really struggling to find time for my open source projects lately, I'd like to give a bit more attention to this but unfortunately can't promise anything

sidorares avatar Aug 26 '19 01:08 sidorares

@sidorares I'm pretty passionate about having this work again. I'd love to help however I can! Would you be interested in help maintaining the project?

CADBOT avatar Aug 27 '19 04:08 CADBOT

Would you be interested in help maintaining the project?

definitely! How much you already know about structure of this project? Old v8 debugger protocol, chrome remote debugging protocol, vim-netbeans etc? Happy to answer any questions

sidorares avatar Aug 27 '19 04:08 sidorares

Not a whole lot, but I'm very willing to learn! I'll dig through the code a bit and reach out to you in the next few weeks via the email on your github after I get situated. Is there a better way to reach you?

CADBOT avatar Sep 04 '19 05:09 CADBOT

Is there a better way to reach you?

email is ok but if you feel discussion can benefit others it's better to do it in the open in GH issues ( if you want to discuss any private matter of security issue of course please email)

sidorares avatar Sep 04 '19 06:09 sidorares