node-mysql2

node-mysql2 copied to clipboard

Open handles potentially keeping Jest from exiting

1

Any idea why jest is not exiting. It shows following as the reason. ``` 39 | async function execute(sql): Promise { > 40 | const [results, fields] = await pool.execute(sql);...

patolax

It was merged march 22nd this year - https://github.com/sidorares/node-mysql2/pull/1340. Any chance we can have another release to address this? Thanks!

lalitkapoor

How to recover closed connection after XA_RBTIMEOUT?

7

My program got XA_RBTIMEOUT error: ``` **failed { Error: XA_RBTIMEOUT: Transaction branch was rolled back: took too long** 2017-05-29 06:02:34|109545|ERROR| at Packet.asError (/userver/bin/src/node_modules/mysql2/lib/packets/packet.js:667:13) 2017-05-29 06:02:34|109545|ERROR| at Query.Command.execute (/userver/bin/src/node_modules/mysql2/lib/commands/command.js:29:22) 2017-05-29 06:02:34|109545|ERROR|...

magicxie

The type of OkPacket.insertId & affectedRows should be number | string?

1

Hi, From lib/packets/resultset_header.js, I found: this.affectedRows = packet.readLengthCodedNumber(bigNumberStrings); this.insertId = packet.readLengthCodedNumberSigned(bigNumberStrings); So I think if the affectedRows or insertId is more than 2^53 - 1, they will be strings rather...

fysntian

Recommendation on connection recycling

13

Based on the recommendation from [AWS Aurora MySQL DBA Handbook](https://d1.awsstatic.com/whitepapers/RDS/amazon-aurora-mysql-database-administrator-handbook.pdf) ``` • Check and validate connections periodically even when they're not borrowed. It helps detect and clean up broken or...

nitsnwits

Query doesn't get committed after a failed pool.query() that had a START TRANSACTION in it

6

Hello, I'm executing 2 queries as follows: ```js const mysql = require('mysql2/promise'); const pool = mysql.createPool(poolConfig = { // ... multipleStatements: true }); await pool.query(/*sql*/` START TRANSACTION; -- something that...

arikw

Change the way types for prepared statement parameters are calculated

5

Currently types are inferred based on what is in the input (Date -> mysql date, js number -> mysql double, everything else - string ). This used to work ok...

sidorares

Promise Pool: Inconsistent types, missing releaseConnection function

4

Hi, I'm looking at implementing a connection pool, using the promise entry, but as I can see [here](https://github.com/sidorares/node-mysql2/blob/131c6b852127bc3af33f542f60231bf19cf99509/promise.js#L318) there isn't a `releaseConnection` function. Additionally, when looking at the standard connection...

perry-mitchell

Expose authPlugins to enable example from docs

2

The example of using `authPlugins` given in https://github.com/sidorares/node-mysql2/blob/master/lib/auth_plugins/caching_sha2_password.md is not possible, as this module does not expose a top level `authPlugin` object. This PR adds that top-level object, as well...

MasterOdin

Incorrect arguments to mysqld_stmt_execute (MySQL 8.0.22)

60

Hi, love this library! Have been using it successfully across a large number of projects and it's worked flawlessly for me so far. Just now I've seen that I have...

perry-mitchell