node-mysql2 icon indicating copy to clipboard operation
node-mysql2 copied to clipboard

More complete way of adding typings for the `Server` module

Open jmordica opened this issue 3 years ago • 3 comments

  • Conformed to the way typings are being added currently in the project
  • Fixed an issue importing PrepareStatementInfo (while we're at it)

jmordica avatar Aug 10 '22 15:08 jmordica

not sure why https://github.com/sidorares/node-mysql2/actions/workflows/code-coverage.yml is still failing, I disabled in manually

Could you add some typings unit tests for types covered in this pr? ( And perhaps ones discussed in https://github.com/sidorares/node-mysql2/pull/1584#issuecomment-1210935539 )

sidorares avatar Aug 11 '22 01:08 sidorares

Looks like checks are failing because the package-lock.json isn't synced with the package.json. I can npm install and add the package-lock.json

jmordica avatar Aug 11 '22 04:08 jmordica

Now that the actual errors are fixed related to typings, i'll add the test for the Server typings.

jmordica avatar Aug 11 '22 04:08 jmordica

@sidorares I've added a new test environment for typings specifically and went ahead and included the Server module. So going forward, anyone that creates new typings will be encouraged to add a test in typings/test and modify the tests.json.

Let me know if this seems over-engineered or if you have any questions. Based on your response, I can also add proper tests for the changes in PR #1584.

jmordica avatar Aug 12 '22 15:08 jmordica