node-mysql2 icon indicating copy to clipboard operation
node-mysql2 copied to clipboard

Missing typescript definition change in released package

Open ymhr opened this issue 3 years ago • 1 comments

Some months ago a PR of mine was merged which added this line https://github.com/sidorares/node-mysql2/blob/master/promise.d.ts#L84 (PR here https://github.com/sidorares/node-mysql2/pull/1262)

Today I installed the latest version of mysql2 and was surprised to see that these changes are actually not included in the package as it was downloaded to my machine.

Looking at the package.json file for the installed version I can see this URL to the NPM registry to download the actual files: https://registry.npmjs.org/mysql2/-/mysql2-2.3.3.tgz After downloading and extracting you can see that the changes are indeed not present.

Has something gone wrong somewhere?

ymhr avatar Feb 02 '22 10:02 ymhr

probably not published yet? I'll try to cut new release some time soon ( right now this involves adding lines to the changelog, npm version patch && git push --tags && npm publish - hope to automate that some time with gh actions )

sidorares avatar Feb 03 '22 02:02 sidorares