node-mysql2 icon indicating copy to clipboard operation
node-mysql2 copied to clipboard

Fix Bad logic to decode the column name #1413

Open testn opened this issue 4 years ago • 3 comments

Introduce character_set_results tracking to ensure that we can read the column name properly

still in the draft mode

testn avatar Oct 16 '21 02:10 testn

@sidorares this is the first attempt trying to fix #1413. It is still rough but it should demonstrate what we can address this problem.

testn avatar Oct 16 '21 02:10 testn

test/integration/connection/encoding/test-track-encodings.js test fails, not sure if your change discovered legitimate error

sidorares avatar Oct 16 '21 06:10 sidorares

@sidorares that exposes the problem that I'm working on a fix. Basically, when you specify character_set_client, you have to encode your SQL in that encoding as well.

testn avatar Oct 16 '21 07:10 testn