node-mysql2
node-mysql2 copied to clipboard
sidorares
release idle connnections after timeout
@yqsailor Checks failed on linting apparently, can you check that ? maybe that way it'll be reviewed, (im looking for that feature too)
This seems like a neat feature. Having this merged after lint fixes would be great.
@sidorares can you check this PR and do a a review of it ? having an idle timeout on this amazing package would make it a perfect package in every sense !
Oh, failed again, What else can I do? Some feedback would be appreciated.
investigating, I think it's a problem in the coverage action and not in your changes
hello guys, any update of this? Wish you to build a release about this, so that we can upgrade this version to our production.
@sidorares Any proceeding, I would gladly use this option in my environment.
@sidorares I would like to use this in my project. Any chance of this getting merged / fixed. Seems to be a test coverage issue, but the logs have been cleaned up already. Wouldn't mind to help out if that increases the chance of this PR getting merged.
@sidorares I've synced the latest master code, may be the test coverage can be passed this time, can you help take a look?
@sidorares any further changes needed to get this PR for "release idle connnections after timeout" over the line?
@vlasky nothing in particular, the change LGTM
for some reason don't see CI run here, it might have been created before migration to GH actions @qingyang-id could you rebase? or maybe @vlasky you can try this branch locally (or re-create PR from this branch and see how tests go)