talos icon indicating copy to clipboard operation
talos copied to clipboard

Expired certs error return connection refused

Open andrewrynhard opened this issue 5 years ago • 2 comments

Bug Report

Description

I'm not sure if this is due to our proxy out of this is a gRPC thing, but an opaque "connection refused error" is returned to the client on a system with an expired certificate. We should fix this.

Logs

Environment

  • Talos version: [talosctl version --nodes <problematic nodes>]
  • Kubernetes version: [kubectl version --short]
  • Platform:

andrewrynhard avatar May 15 '20 12:05 andrewrynhard

When a client submits an invalid client certificate (e.g. expired), the termination happens early in the TLS handshake before any application layer is established, so returning a descriptive error is impossible I believe.

What can be done - is client-side check for an expired cert, this will be more user-friendly, but this should be a warning imho to account for clock skew.

smira avatar Apr 03 '23 14:04 smira

@smira It might, at least, be worthwhile to have an insecure-accessable endpoint to pull node-time though. So we can actually check which of the two is out-of-sync. (which can happen, for example, with unreachable ntp servers)

PrivatePuffin avatar Jun 29 '24 09:06 PrivatePuffin

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Dec 27 '24 02:12 github-actions[bot]

This issue was closed because it has been stalled for 7 days with no activity.

github-actions[bot] avatar Jan 01 '25 02:01 github-actions[bot]