Josh Holmer

Results 136 comments of Josh Holmer

Thanks for filing this. If you add the env var `RUST_BACKTRACE=1` to the command then Rust will print out a full backtrace.

It appears the only remaining place where this needs to be fixed is in `AlignedArray::uninitialized`.

I'm still seeing this issue as well in 4.6.5 + libtorrent 2.0.10. I'm on linux with btrfs + mdraid-5 on top of rotational disks, but that seems irrelevant to what...

Sorry for not looking at this sooner. Yes, this looks good. Thanks.

It probably makes sense to just bake it into the existing `ser` feature. The reason the feature would be desired is to avoid depending on serde if not needed. If...

Thanks for mentioning this! This implementation should be safe as it does [only check the first 100 characters](https://github.com/shssoichiro/zxcvbn-rs/blob/master/src/lib.rs#L135), the assumption being that if you have a password longer than that,...

Thanks for confirming @jun-sheaf ! I'll mark this as closed then.

Looks like there's a feature missing on one of the dependencies, that's conditionally required for wasm.

As someone who is not an expert on wasm, I have no idea why the wasm tests are failing saying that `f32` and `f64` do not have a `round` method....

Is there a recommended fix? The one that comes to mind for me is to only include the `round` methods if `std` is included. Edit: I see that there's e.g....