showdown icon indicating copy to clipboard operation
showdown copied to clipboard

Strip more international punctuation characters from header ids in `ghCompatibleHeaderId` mode

Open tunetheweb opened this issue 3 years ago • 3 comments

GitHub currently strips the following extended punctuation characters when creating headers in markdown files, but Showdown does not.

Evidence in this gist: https://gist.github.com/tunetheweb/ecbfed99663425a668748770568bdafb#some-header-with--chars

Seems an easy enough fix to add these so will submit a PR.

tunetheweb avatar Aug 07 '22 13:08 tunetheweb

Hey.

Do you mean GitHub strips these characters from ids?

tivie avatar Nov 14 '22 17:11 tivie

Correct. If you look at that gist example (markdown gists automatically creates ids) you see it:

image

tunetheweb avatar Nov 14 '22 17:11 tunetheweb

Thank you. Will be merging the PR.

tivie avatar Nov 14 '22 18:11 tivie