operator
operator copied to clipboard
Fix: Add a check for tektonconfig status
Changes
Added a check for tektonconfig before progressing in the reconciliation process.
Fixes #167
Submitter Checklist
- [ x ] Includes tests if functionality changed/was added
- [ ] Includes docs if changes are user-facing
- [ ] Set a kind label on this PR
- [ x ] Release notes block has been filled in, or marked NONE
See the contributor guide for details on coding conventions, github and prow interactions, and the code review process.
Release Notes
Fix: build status reports ready early when tektonconfig is at Error/not available state
Test still needs fixing
Thanks for the review @adambkaplan . Did the changes.
Cleaning up tests
I have updated some tests to create the tektonconfig since its status being ready is now required after the fix
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: adambkaplan
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [adambkaplan]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Thanks for the points @adambkaplan ! I have refactored the logic to improve its clarity and error handling.
The e2e appeared to have flaked - timed out waiting for the operator pod to become ready. We may consider increasing the timeout from 5m to 10 or 15 minutes (in a separate pull request).
/hold cancel
We can merge this now that Shipwright v0.16.0 has been released.
/retest
For some reason GH actions isn't working. Going to close + reopen the PR to see if it fixes the issue.
@adambkaplan I reran the failed actions