operator icon indicating copy to clipboard operation
operator copied to clipboard

Fix: Add a check for tektonconfig status

Open hasanawad94 opened this issue 6 months ago • 6 comments

Changes

Added a check for tektonconfig before progressing in the reconciliation process.

Fixes #167

Submitter Checklist

  • [ x ] Includes tests if functionality changed/was added
  • [ ] Includes docs if changes are user-facing
  • [ ] Set a kind label on this PR
  • [ x ] Release notes block has been filled in, or marked NONE

See the contributor guide for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

Fix: build status reports ready early when tektonconfig is at Error/not available state

hasanawad94 avatar May 11 '25 13:05 hasanawad94

Test still needs fixing

hasanawad94 avatar May 11 '25 13:05 hasanawad94

Thanks for the review @adambkaplan . Did the changes.

hasanawad94 avatar May 14 '25 13:05 hasanawad94

Cleaning up tests

hasanawad94 avatar May 22 '25 15:05 hasanawad94

I have updated some tests to create the tektonconfig since its status being ready is now required after the fix

hasanawad94 avatar May 23 '25 12:05 hasanawad94

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jun 03 '25 18:06 openshift-ci[bot]

Thanks for the points @adambkaplan ! I have refactored the logic to improve its clarity and error handling.

hasanawad94 avatar Jun 10 '25 11:06 hasanawad94

The e2e appeared to have flaked - timed out waiting for the operator pod to become ready. We may consider increasing the timeout from 5m to 10 or 15 minutes (in a separate pull request).

adambkaplan avatar Jun 10 '25 20:06 adambkaplan

/hold cancel

We can merge this now that Shipwright v0.16.0 has been released.

adambkaplan avatar Jul 29 '25 13:07 adambkaplan

/retest

adambkaplan avatar Aug 21 '25 14:08 adambkaplan

For some reason GH actions isn't working. Going to close + reopen the PR to see if it fixes the issue.

adambkaplan avatar Aug 25 '25 12:08 adambkaplan

@adambkaplan I reran the failed actions

hasanawad94 avatar Aug 26 '25 08:08 hasanawad94