build
build copied to clipboard
Initial TaskRun Reconcile Refactor
Changes
This is a refactor of how we reconcile TaskRun objects into BuildRun objects. The intent is to create useful abstractions of the TaskRun's lifecycle so that we can extend these principles to other Kubernetes object types.
/kind cleanup
Submitter Checklist
- [x] Includes tests if functionality changed/was added
- [x] Includes docs if changes are user-facing
- [x] Set a kind label on this PR
- [x] Release notes block has been filled in, or marked NONE
See the contributor guide for details on coding conventions, github and prow interactions, and the code review process.
Release Notes
NONE
/assign @SaschaSchwarze0
/cc @HeavyWombat @karanibm6
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from saschaschwarze0. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
I think I fixed all the issues identified in the review (or addressed them in comments). PTAL.
/close
Going to use #1924 as a starting point instead - this has all tests passing and has fewer changes.
@adambkaplan: Closed this PR.
In response to this:
/close
Going to use #1924 as a starting point instead - this has all tests passing and has fewer changes.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.