build
build copied to clipboard
Add NodeSelectors to Build and BuildRun objects
Changes
Allows NodeSelector to be set on Build and BuildRun objects.
Fixes #1635
Submitter Checklist
- [x] Includes tests if functionality changed/was added
- [x] Includes docs if changes are user-facing
- [x] Set a kind label on this PR
- [x] Release notes block has been filled in, or marked NONE
See the contributor guide for details on coding conventions, github and prow interactions, and the code review process.
Release Notes
Added NodeSelector on Build and BuildRun objects, which enables specifying the scheduling behavior of TaskRuns.
hi @dorzel. We will check soon your PR, sorry for the delay.
hi @dorzel. We will check soon your PR, sorry for the delay.
Ah, no problem and no rush at all. Looks like I have some test fixes to look into
/kind feature
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: SaschaSchwarze0
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [SaschaSchwarze0]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi @adambkaplan, would you be able to take a look now that we have tests passing? Thank you!