build icon indicating copy to clipboard operation
build copied to clipboard

Add NodeSelectors to Build and BuildRun objects

Open dorzel opened this issue 1 year ago • 4 comments

Changes

Allows NodeSelector to be set on Build and BuildRun objects.

Fixes #1635

Submitter Checklist

  • [x] Includes tests if functionality changed/was added
  • [x] Includes docs if changes are user-facing
  • [x] Set a kind label on this PR
  • [x] Release notes block has been filled in, or marked NONE

See the contributor guide for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

Added NodeSelector on Build and BuildRun objects, which enables specifying the scheduling behavior of TaskRuns.

dorzel avatar Sep 17 '24 19:09 dorzel

hi @dorzel. We will check soon your PR, sorry for the delay.

qu1queee avatar Sep 27 '24 08:09 qu1queee

hi @dorzel. We will check soon your PR, sorry for the delay.

Ah, no problem and no rush at all. Looks like I have some test fixes to look into

dorzel avatar Sep 27 '24 16:09 dorzel

/kind feature

dorzel avatar Oct 02 '24 17:10 dorzel

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [SaschaSchwarze0]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Oct 12 '24 20:10 openshift-ci[bot]

Hi @adambkaplan, would you be able to take a look now that we have tests passing? Thank you!

dorzel avatar Oct 22 '24 16:10 dorzel