build icon indicating copy to clipboard operation
build copied to clipboard

fix: update the storage-version-migration script to complete execution in finite time

Open ayushsatyam146 opened this issue 1 year ago • 2 comments

Changes

hack/storage-version-migration.sh script is mentioned in the install steps. If that script is executed it runs infinitely without reporting any success or failure. This PR adds changes to put checks in hack/storage-version-migration.sh script to give success or failure response and terminate the execution in finite time.

Fixes #1680

Submitter Checklist

  • [ ] Includes tests if functionality changed/was added
  • [ ] Includes docs if changes are user-facing
  • [x] Set a kind label on this PR
  • [x] Release notes block has been filled in, or marked NONE

See the contributor guide for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

ayushsatyam146 avatar Sep 16 '24 09:09 ayushsatyam146

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign adambkaplan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Sep 16 '24 09:09 openshift-ci[bot]

/hold

This PR needs to be rebased, and has outstanding comments that have not been addressed.

adambkaplan avatar Aug 26 '25 18:08 adambkaplan