ember-prism icon indicating copy to clipboard operation
ember-prism copied to clipboard

Improve usage of custom Prism themes

Open gregone opened this issue 4 years ago • 3 comments

As I found when working on https://github.com/MelSumner/ember-a11y-for/pull/14 , using a non-standard theme (i.e not in the main prismjs package) is quite convoluted.

Having the option to not include any css when explicitly using 'none' instead of the default theme would help some of these issues.

see: https://github.com/shipshapecode/ember-prism/blob/f352008fb699ea05a1554140902c71798419e007/index.js#L23

gregone avatar Oct 27 '21 14:10 gregone

@gregone would you be interested in opening a PR to fix the issue?

RobbieTheWagner avatar Nov 02 '21 01:11 RobbieTheWagner

@rwwagner90 Sure, I can do that. Would it be ok if made theme: 'none' work as expected, i.e no css at all?

gregone avatar Nov 02 '21 16:11 gregone

@gregone could we do theme: false instead perhaps?

RobbieTheWagner avatar Nov 03 '21 14:11 RobbieTheWagner