laravel-elasticsearch
laravel-elasticsearch copied to clipboard
The default config file is not cacheable
Trying to run php artisan config:cache on a project with this package installed fails because commit 10c3a1fc69583882e3c0f696505f00813de7e2ae introduced a not serializable value on the config file. The logger is now created on the config file instead of on the Service Provider.
Unless you have a very good reason for this, I can make a PR moving that code back to the service provider and restoring the logPath and logLevel on the config file. I guess I could make it backwards compatible that only if you don't have the logger on the config file it gets created on the service provider.
Let me know what you think.
Hello @j3j5 ,
Can you please share with me the version you use and also the version of laravel/lumen framework?
Hi @candasm, I'm using Laravel 6 and laravel-elasticsearch 4.5.1 although the issue will surface on Laravel 5 as well, since afaik the call to create the default logger from the builder class won't be serializable anyway.