shepherd icon indicating copy to clipboard operation
shepherd copied to clipboard

Upgrade from popperjs to floating-ui

Open theodoreb opened this issue 3 years ago • 6 comments

Hello,

The popperjs library kinda "rebranded" to https://github.com/floating-ui/floating-ui, are there any plan to make the switch for shepherd?

In Drupal and we're going to update our code to use floating-ui instead of popperjs. And since we use shepherd and shepherd uses popperjs it'd be great to not have two different libraries for that.

Are there any plans or interest in moving over to floating-ui? in a few weeks we should be able to help with making a PR to switch, before spending time on it I just wanted to make sure it's a welcome change :)

theodoreb avatar Aug 05 '22 08:08 theodoreb

@theodoreb we are always interested in staying current, so yes we would fully support this. If you could sync up with @EmNicholson93 he should be able to help with this effort.

RobbieTheWagner avatar Aug 05 '22 13:08 RobbieTheWagner

For planning purpose on our side, do you think switching the helper library will translate to a major version bump for shepherd ?

theodoreb avatar Aug 22 '22 14:08 theodoreb

@theodoreb only if the public Shepherd API changes. I'm not afraid of a major version bump, but if we don't need it, we could just do a minor.

RobbieTheWagner avatar Aug 22 '22 19:08 RobbieTheWagner

The public API seems to imply the popper API is part of shepherd since there is a popperOptions: Extra options to pass to [Popper](https://popper.js.org/docs/v2/constructors/#options)

Which would mean deprecating/removing that option => so major bump seems likely

theodoreb avatar Aug 23 '22 15:08 theodoreb

I have time to work on this tomorrow FYI

theodoreb avatar Aug 24 '22 14:08 theodoreb

started in https://github.com/shipshapecode/shepherd/compare/master...theodoreb:floating-ui?expand=1

theodoreb avatar Aug 25 '22 15:08 theodoreb