seqkit icon indicating copy to clipboard operation
seqkit copied to clipboard

Please bump golang.org/x/sys dependency

Open clausecker opened this issue 2 years ago • 5 comments

The version of golang.org/x/sys you ship is outdated and doesn't support some newer platforms like riscv64-freebsd.

Please update the dependency to enable a build there. The same applies to some of your other projects, too.

clausecker avatar Mar 17 '23 17:03 clausecker

Thanks for the information. But will the update break the compatibility for some old operating systems, especially those running on the old servers?

For example:

Ports
Windows
Go 1.20 is the last release that will run on any release of Windows 7, 8, Server 2008 and Server 2012. Go 1.21 will require at least Windows 10 or Server 2016.

Darwin and iOS
Go 1.20 is the last release that will run on macOS 10.13 High Sierra or 10.14 Mojave. Go 1.21 will require macOS 10.15 Catalina or later.

FreeBSD/RISC-V
Go 1.20 adds experimental support for FreeBSD on RISC-V (GOOS=freebsd, GOARCH=riscv64).
Linux
Go 1.18 requires Linux kernel version 2.6.32 or later.

I don't know whether the statically-linked binaries will still be affected.

shenwei356 avatar Mar 20 '23 09:03 shenwei356

Hi,

I'm asking you to bump the version of a dependency, not of the Go toolchain itself. The most recent version of golang.org/x/sys requires Go 1.17 to build. That supports quite a few older operating systems than Go 1.20. In the end, it's your choice to make. Support old outdated operating systems or more recent platforms.

clausecker avatar Mar 20 '23 12:03 clausecker

I see. Thank you Robert!

shenwei356 avatar Mar 20 '23 13:03 shenwei356

Please note that this update is also needed for other projects of yours, such as csvtk. I additionally found a portability issue in your fork of the pospop routines, which I will address separately.

clausecker avatar Mar 20 '23 13:03 clausecker

Thanks for reminding me. I appreciate your kind help.

shenwei356 avatar Mar 21 '23 00:03 shenwei356