django-vote icon indicating copy to clipboard operation
django-vote copied to clipboard

Published 20 hours ago • verified publisher icon shellfly

Update index definition to be compatible with Django 5

Open Barthelemy opened this issue 7 months ago • 6 comments

fix #88

Barthelemy avatar Apr 16 '25 14:04 Barthelemy

@Barthelemy, thanks for the PR. Based on the document, it needs a migration to rename the index. Could you add it as well? Also, please update the CI config to include tests for Django 5.2

shellfly avatar Apr 17 '25 01:04 shellfly

Thanks for the comment. I did not realize that the migration should be part of the PR, sorry about that. I will also update the CI config.

Barthelemy avatar Apr 17 '25 06:04 Barthelemy

I have added the migration that Django generated. I am not sure why there is the AlterField though.

Barthelemy avatar Apr 17 '25 08:04 Barthelemy

I have added the migration that Django generated. I am not sure why there is the AlterField though.

It's probably related to this change. Could you set DEFAULT_AUTO_FIELD before generating the migration so that the migration is clean for this PR

shellfly avatar Apr 17 '25 09:04 shellfly

Things are never as simple as we thought...

Given that the django versions still supported are 4.2, 5.1 and 5.2 I would propose to keep only the support for 4.2.20, 5.1.9, 5.2.1. RenameIndex was introduced in 4.1. However that might not be what you want ?

Barthelemy avatar Apr 30 '25 06:04 Barthelemy

@Barthelemy, please go ahead and update the supported versions. Users can always use the previous tag version if needed.

shellfly avatar May 03 '25 13:05 shellfly