ngx-carousel icon indicating copy to clipboard operation
ngx-carousel copied to clipboard

Vertical Carousel Option

Open Tomdrouv1 opened this issue 8 years ago • 4 comments

Hi @sheikalthaf,

First, thanks for this library, I used ngx-slick in my angular app before using ngx-carousel and now my app is faster because ngx-slick has JQuery as dependency.

But there is an option in ngx-slick that would be great in your library : vertical carousel. 😃

Do you think it's possible to implement it ?

Tomdrouv1 avatar Nov 16 '17 13:11 Tomdrouv1

@Tomdrouv1 @iamlothian I will try to implement it. I can't sure without trying it. Thanks for your love.

sheikalthaf avatar Nov 16 '17 16:11 sheikalthaf

@sheikalthaf Having looked through the code. I would assume this would cause quite a branching in the implementations, ss it affects the touch logic and the slide transitions. This could be a good oppertunity to abstract those parts into their own services that can be chosen during config.

My inital thoughts would be to seporate the logic out into providers. As there are afew current and desired styles of caraousels.

  • horisontal slider
  • vertical slider
  • horisontal slider with touch
  • vertical slider with touch
  • horisontal tiles
  • vertical tiles
  • horisontal tiles with touch
  • vertical tiles with touch

The current implementation using a gloabl transition across all slides, while simple and effective is restrictive and doesn't scale well. Hiding destorying hidden slides and delegating the transition to a slide itself will open up many possabilities, like mixing transitions types and slide types.

This would be a big task though.

iamlothian avatar Nov 16 '17 17:11 iamlothian

@iamlothian Really amazing to see the tasks. I love the challenges. let's do that. hope you guide me with your plan.

sheikalthaf avatar Nov 16 '17 18:11 sheikalthaf

@iamlothian Based on your suggestion I'm going to change the concept of the carousel with flexible options.

sheikalthaf avatar Nov 26 '17 07:11 sheikalthaf