beginners-guide-html-css icon indicating copy to clipboard operation
beginners-guide-html-css copied to clipboard

Note on 'bad code' example 2 in Lesson 12

Open JohannesMP opened this issue 7 years ago • 0 comments
trafficstars

The first section, "Write Standards-Compliant Markup", covers incorrect nesting of tags. The next section, "Make Use of Semantic Elements", covers using semantic elements instead of meaningless classes/etc.

However the 'bad code' example for the second section once again uses incorrect tag nesting: image

I feel that this point was already made in the previous section, and that once again having the tags nested incorrectly may be diluting the message of what this example is meant to illustrate. It should focus on one 'bad' thing instead of two.

I would recommend changing the 'Bad Code' section of the "Make Use of Semantic Elements" section to:

<span class="heading"><strong>Welcome Back</strong></span>
...

Just to be completely clear on which bad practice is being covered in that section.

JohannesMP avatar Mar 26 '18 03:03 JohannesMP