json-object-mapper icon indicating copy to clipboard operation
json-object-mapper copied to clipboard

Published 20 hours ago • verified publisher icon shakilsiraj

Readme should be updated with working example

Open michalzubkowicz opened this issue 7 years ago • 6 comments

Example from Readme doesn't work properly with TypeScript.

It should be updated or have info about that all classess used by object mapper must be created with constructor or marked all fields as undefined

michalzubkowicz avatar Jun 07 '18 05:06 michalzubkowicz

We use this in production so this library works in most cases, however it does not seem to be maintained. None of my pull requests are being reviewed :(

artonio avatar Jun 08 '18 14:06 artonio

Sorry guys, I have been busy with other things .. didn't look at this for a while..

@artonio .. see release 1.6.0 @michalzubkowicz - that's a requirement for typescript and there are plenty of examples in the spec files.

shakilsiraj avatar Jul 06 '18 07:07 shakilsiraj

Deserialization does not work. I got empty object. Default settings, angular 6 project. Serialization works properly.

ghost avatar Aug 16 '18 15:08 ghost

@t-gawel-samsung , did you set all properties of object as undefined explictly?

michalzubkowicz avatar Aug 19 '18 19:08 michalzubkowicz

@michalzubkowicz yes, I finally found it is a fix. But this information is missing in the docs, or I just overlooked it?

ghost avatar Aug 20 '18 11:08 ghost

@t-gawel-samsung - yes, it's missing in docs. It's in spec files, but nice would be to have it in example as I mentioned before.

michalzubkowicz avatar Aug 20 '18 11:08 michalzubkowicz