Shakeel Mohamed

Results 97 comments of Shakeel Mohamed

@joaniedavis there's plenty to do :) I would spend a few minutes playing around with the website and look to add some test that hit basic scenarios: * searching and...

@joaniedavis yeah those seem like a great starting place. Yes, feel free to split up the tests into smaller files

@joaniedavis thanks, take your time. I'm more concerned with having functional tests that simulate user behavior than unit tests at this time. I think once we have sufficient functional tests...

@joaniedavis sure, let's take a look at what you've got so far and I can provide some pointers

Thanks for the PR @naomiceron, pardon my delay in reviewing. Functionality seems solid, mainly two pieces of feedback. 1. I think this extra nested layer of the community favorite button...

> Thank you! @shakeelmohamed, should I remove the community button entirely? I ask because of the second point Yeah that makes sense to me

@jbecker7 Hey welcome! Go for it, please read through all comments in this PR and look at the changes before submitting your own

I've left some comments bold inline above to help whoever ends up doing these tasks, thanks for triaging @josectello!

@josectello aside from the first item on the list, I think the others make sense being on the wiki. What do you think?

@josectello that makes sense, we can add a link to the wiki at the end of the contributing section of the README 👍