react_on_rails
react_on_rails copied to clipboard
shakacode
Integration of React + Webpack + Rails + rails/webpacker including server-side rendering of React, enabling a better developer experience and faster client performance.
### Summary Tests in `node_package/tests/RSCClientRoot.test.jsx` were calling `act` without `await`, leading to these warnings: > You called act(async () => ...) without await. This could lead to unexpected testing behaviour,...
### Summary _Remove this paragraph and provide a general description of the code changes in your pull request... were there any bugs you had fixed? If so, mention them. If...
docs/guides/tutorial.md currently says `Updated for Ruby 2.7, Rails 7, React on Rails v13, and Shakapacker v7`. Ruby and RoR should be updated. In particular, use `react-on-rails/client` if it makes sense.
Since we use Gatsby to build the website, and it uses Remark to process Markdown, https://github.com/remarkjs/remark-lint should check its validity. It should include a [custom rule](https://github.com/DavidAnson/markdownlint/blob/main/doc/CustomRules.md) to ban relative links...
### Summary _Remove this paragraph and provide a general description of the code changes in your pull request... were there any bugs you had fixed? If so, mention them. If...
Currently the badge in our README for https://coveralls.io/github/shakacode/react_on_rails?branch=master is tied to Travis, which we don't use, and has very old data. Fix this. See https://docs.coveralls.io/. Include our other open-source repos...
See https://github.com/sds/scss-lint?tab=readme-ov-file#notice-consider-other-tools-before-adopting-scss-lint. Since Stylelint v16+ doesn't have rules conflicting with Prettier, https://github.com/prettier/stylelint-prettier shouldn't be necessary.
E.g. we have https://github.com/shakacode/react_on_rails/blob/846d02dd955f8a1aee1e6d5f01a9ec48e9bfef89/docs/guides/hmr-and-hot-reloading-with-the-webpack-dev-server.md?plain=1#L34 but `devServer.inline` doesn't seem to exist and the option may have been removed on our side too.
The equivalent of https://github.com/shakacode/react_on_rails/pull/1671.
Probably using K6 for consistency with the new React on Rails Pro load tests. For reference: https://github.com/shakacode/react_on_rails_pro/pull/453, https://github.com/shakacode/react_on_rails_pro/issues/458, https://github.com/shakacode/react_on_rails/pull/1555.