shaka-player-embedded icon indicating copy to clipboard operation
shaka-player-embedded copied to clipboard

Additional ShakaPlayerError arguments

Open okycelt opened this issue 4 years ago • 2 comments

As per docs, Shaka Player's shaka.util.Error has varArgs. However, there is no way to access these arguments in Shaka Player Embedded's ShakaPlayerError except parsing the ShakaPlayerError.message string, which is far from ideal. We use it e.g. to get the actual response from Widevine proxy when the player throws the 6007 LICENSE_REQUEST_FAILED error. Would it be possible to somehow support varArgs in ShakaPlayerError?

Thanks in advance

okycelt avatar Nov 27 '20 03:11 okycelt

We could add that. One problem is that in JavaScript, these are any kind of value, but that doesn't work well in C++. We'd probably just convert these to strings. So there'd be an array of strings for the data field.

TheModMaker avatar Nov 30 '20 18:11 TheModMaker

That should probably be sufficient. Thank you.

okycelt avatar Dec 22 '20 07:12 okycelt