FreeCAD_SheetMetal icon indicating copy to clipboard operation
FreeCAD_SheetMetal copied to clipboard

Can we have properties converted to Title Case to match Freecad style?

Open leoheck opened this issue 1 year ago • 15 comments
trafficstars

Hey @shaise nice to meet you here. I did not know that this was also your work. What do you think about updating property names on this Workbench too?

image

leoheck avatar Jun 20 '24 02:06 leoheck

Yes, I had a feeling it will come into this. Sheetmetal is a bit more complicated in that matter. But I will take a look as well.

shaise avatar Jun 20 '24 05:06 shaise

Yes, I had a feeling it will come into this.

Sorry to give you this much work dude!

leoheck avatar Jun 20 '24 13:06 leoheck

I guess there would need to be a slow deprecation process whereby the deprecated properties need to be converted by a script for backward compatibility, notify the user that older versions of SheetMetal addon aren't compatible... ?

luzpaz avatar Sep 10 '24 09:09 luzpaz

What if the priperties are read from the file as case insensitive, and converted to the title case internally. When saving the file, the title case is used?

leoheck avatar Sep 10 '24 20:09 leoheck

I think that I will probably end up doing the same as I did in Fasteners. Only reason I postponed it is because I need to see how I merge the changes that were done for Ondsel's sheetmetel.

shaise avatar Sep 10 '24 21:09 shaise

@shaise is this still relevant ?

luzpaz avatar Dec 04 '24 18:12 luzpaz

Actually, with my new changes, it is rather easy now to change parameter names and still be compatible with old files (it will rename them as soon as a change is made) However, since there is a much more comfortable UI Task Panel, I'm not sure it is necessary.

shaise avatar Dec 04 '24 19:12 shaise

UI Task Panel

Which UI Task Panel?

leoheck avatar Dec 04 '24 19:12 leoheck

with the new version, there is a task panel for this function

shaise avatar Dec 04 '24 19:12 shaise

The new version of Freecad or the Workbench? So no properties on the properties panel anymore?

leoheck avatar Dec 04 '24 20:12 leoheck

new version of sheetmetal: image

shaise avatar Dec 04 '24 20:12 shaise

Nice, and those settings won't be visible on the properties panel?

leoheck avatar Dec 04 '24 21:12 leoheck

the property panel is the low level of any feature and will always work. The UI is only a helper.

shaise avatar Dec 04 '24 22:12 shaise

But can we have the title case on the property panel as well to mimic other properties? This will give the professional look that Freecad deserves.

leoheck avatar Dec 04 '24 22:12 leoheck

@luzpaz , what do you think?

shaise avatar Dec 05 '24 06:12 shaise