libQtShadowsocks icon indicating copy to clipboard operation
libQtShadowsocks copied to clipboard

libqtshadowsocks doesn't build anymore against Botan 2.11.0

Open david-geiger opened this issue 6 years ago • 1 comments

Hi,

I tried to build libqtshadowsocks on Mageia Cauldron against Botan 2.11.0 but it fails to build due to:

/home/iurt/rpmbuild/BUILD/libQtShadowsocks-2.1.0/lib/crypto/cipher.cpp: In constructor 'QSS::Cipher::Cipher(const string&, std::__cxx11::string, std::__cxx11::string, bool)': /home/iurt/rpmbuild/BUILD/libQtShadowsocks-2.1.0/lib/crypto/cipher.cpp:94:25: error: 'get_cipher' is not a member of 'Botan' filter = Botan::get_cipher(cipherInfo.internalName, _key, _iv, ^~~~~~~~~~

Attached full log:

build.0.20190715095032.log

david-geiger avatar Jul 15 '19 10:07 david-geiger

Hmmm! ok! "get_cipher" was moved into "botan/filters.h" header

This patch fixes build:

`diff -Nrup a/lib/crypto/cipher.cpp b/lib/crypto/cipher.cpp --- a/lib/crypto/cipher.cpp 2018-04-21 00:51:05.000000000 +0200 +++ b/lib/crypto/cipher.cpp 2019-07-15 17:59:49.560274979 +0200 @@ -26,6 +26,7 @@ #include

#include <botan/auto_rng.h> +#include <botan/filters.h> #include <botan/key_filt.h> #include <botan/lookup.h> #include <botan/md5.h>`

david-geiger avatar Jul 15 '19 16:07 david-geiger