slang icon indicating copy to clipboard operation
slang copied to clipboard

[SPIR-V] Fix error of extern function signature

Open GinShio opened this issue 5 months ago • 2 comments

As for extern function, it's not definition, that is no params. After legalize, the function type hasn't params, it's a error signature.

When we fix the function type, extern function should check the param types in function type instead of params.

GinShio avatar Jun 15 '25 12:06 GinShio

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 15 '25 12:06 CLAassistant

It based on PR #7447. SPIR-V validation:

error: line 28: Function declaration (id 7) must have a LinkageAttributes decoration with the Import Linkage type.
  %f = OpFunction %int None %8

GinShio avatar Jun 16 '25 11:06 GinShio

Close this PR and then merge into #7447.

GinShio avatar Jul 19 '25 09:07 GinShio