ui icon indicating copy to clipboard operation
ui copied to clipboard

feat:toggle group

Open KXLAA opened this issue 2 years ago • 6 comments

This PR add the Toggle group component, you can see the demo of how it looks on both light & dark modes below:

2023-02-03 10 01 13 pm

KXLAA avatar Feb 03 '23 21:02 KXLAA

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
next-template ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 7, 2023 at 9:04AM (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 7, 2023 at 9:04AM (UTC)

vercel[bot] avatar Feb 03 '23 21:02 vercel[bot]

Someone is attempting to deploy a commit to a Personal Account owned by @shadcn on Vercel.

@shadcn first needs to authorize it.

vercel[bot] avatar Feb 03 '23 21:02 vercel[bot]

@KXLAA This is a great start. Can you update the style to match the new <Toggle /> component we just added? We are looking for default and outline variants.

shadcn avatar Feb 04 '23 06:02 shadcn

@KXLAA This is looking good. If it's OK with you, I'll push a few minor style fixes and then we can merge.

shadcn avatar Feb 04 '23 17:02 shadcn

@KXLAA This is looking good. If it's OK with you, I'll push a few minor style fixes and then we can merge.

Sure thing. Thanks

KXLAA avatar Feb 04 '23 17:02 KXLAA

Is this not ready to go?

filipjnc avatar Jun 11 '23 20:06 filipjnc

@KXLAA please use this plugin to sort the classes and get rid of the whitespaces: https://github.com/tailwindlabs/prettier-plugin-tailwindcss

filipjnc avatar Jul 03 '23 11:07 filipjnc

I'll take a look at this again. Assigning...

shadcn avatar Sep 18 '23 12:09 shadcn

@KXLAA Would you be ok if we go with this (updated) PR https://github.com/shadcn-ui/ui/pull/1547 for the toggle group? I appreciate that you were the first one with the toggle group implementation. Thank you.

shadcn avatar Nov 12 '23 11:11 shadcn

@KXLAA Would you be ok if we go with this (updated) PR #1547 for the toggle group? I appreciate that you were the first one with the toggle group implementation. Thank you.

yeah sure, thank you

KXLAA avatar Nov 12 '23 12:11 KXLAA

Thanks @KXLAA. Appreciate it!

shadcn avatar Nov 12 '23 18:11 shadcn